Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CalendarEditIcon #500

Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: add CalendarEditIcon #500

merged 4 commits into from
Oct 7, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 25, 2024 •
edited
Loading

This PR adds new Calendar Edit Icon.

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:07pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 79fee04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

❌ Deploy Preview for cube-uikit-docs failed.

Name Link
🔨 Latest commit 79fee04
🔍 Latest deploy log https://app.netlify.com/sites/cube-uikit-docs/deploys/6703f9176cdb0600087960d3

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-bddaa5b.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://6703f957ef0f1629e2b965ce--cube-uikit-docs.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

🧪 Storybook is successfully deployed!

@KSDaemon KSDaemon mentioned this pull request Sep 25, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024 •
edited
Loading

🏋️ Size limit report

Name Size Passed?
All 217.32 KB (+0.52% 🔺) Yes 🎉
Tree shaking (just a Button) 34.38 KB (+3.73% 🔺) Yes 🎉
Tree shaking (just an Icon) 22.95 KB (+5.36% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit 4c65f30 into main Oct 7, 2024
13 of 17 checks passed
@tenphi tenphi deleted the feat/calendar-edit-icon branch October 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenphi tenphi Awaiting requested review from tenphi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSDaemon @tenphi